netdev - Re: [PATCH] can: m_can: remove redundant check for pm_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240216-panning-sesame-2bc66afeeb6a-mkl@pengutronix.de>
Date: Fri, 16 Feb 2024 08:56:00 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Francesco Dolcini <francesco@...cini.it>
Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>, 
	Chandrasekar Ramakrishnan <rcsekar@...sung.com>, Wolfgang Grandegger <wg@...ndegger.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Francesco Dolcini <francesco.dolcini@...adex.com>, linux-can@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: m_can: remove redundant check for pm_clock_support

On 16.02.2024 08:45:27, Francesco Dolcini wrote:
> Hello Marc and Vincent,
> 
> On Fri, Jan 05, 2024 at 12:57:23AM +0100, Francesco Dolcini wrote:
> > From: Francesco Dolcini <francesco.dolcini@...adex.com>
> > 
> > m_can_clk_start() already skip starting the clock when
> > clock support is disabled, remove the redundant check in
> > m_can_class_register().
> > 
> > This also solves the imbalance with m_can_clk_stop() that is called
> > afterward in the same function before the return.
> > 
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> 
> Did you missed this? Or do you have some concern with it?

Somehow missed it in the last PR, but already part of the next PR.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)