netdev - Re: [PATCH net 2/2] ipv6: properly combine dev_base_seq and ipv6.dev_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c59b80a8-cf9a-4e16-a298-6bb9b4b367a0@6wind.com>
Date: Fri, 16 Feb 2024 10:17:07 +0100
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
 eric.dumazet@...il.com
Subject: Re: [PATCH net 2/2] ipv6: properly combine dev_base_seq and
 ipv6.dev_addr_genid

Le 15/02/2024 à 18:21, Eric Dumazet a écrit :
> net->dev_base_seq and ipv6.dev_addr_genid are monotonically increasing.
> 
> If we XOR their values, we could miss to detect if both values
> were changed with the same amount.
> 
> Fixes: 63998ac24f83 ("ipv6: provide addr and netconf dump consistency info")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

The trailers are mangled, your sob is put twice.

Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>