netdev - RE: [PATCH v3 iproute2] ifstat: convert sprintf to snprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <369729fa83564583acbb5c7903641867@AcuMS.aculab.com>
Date: Sat, 17 Feb 2024 17:51:01 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Denis Kirjanov' <kirjanov@...il.com>, "stephen@...workplumber.org"
	<stephen@...workplumber.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Denis Kirjanov
	<dkirjanov@...e.de>
Subject: RE: [PATCH v3 iproute2] ifstat: convert sprintf to snprintf

From: Denis Kirjanov
> Sent: 14 February 2024 12:57
> 
> Use snprintf to print only valid data

... to avoid potentially overflowed the temporary buffer.

Also probably worth using scnprintf() to avoid another change
when snprintf() is removed (because the return value is dangerous).

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)