netdev - Re: [PATCH iproute2 v8 1/3] ss: add support for BPF socket-local storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <576ebc9e-4307-4e01-9b41-12aaac83b14a@gmail.com>
Date: Sun, 18 Feb 2024 10:39:04 -0700
From: David Ahern <dsahern@...il.com>
To: Quentin Deslandes <qde@...cy.de>, netdev@...r.kernel.org
Cc: Martin KaFai Lau <martin.lau@...nel.org>,
 Stephen Hemminger <stephen@...workplumber.org>, kernel-team@...a.com,
 Matthieu Baerts <matttbe@...nel.org>
Subject: Re: [PATCH iproute2 v8 1/3] ss: add support for BPF socket-local
 storage

On 2/14/24 1:42 AM, Quentin Deslandes wrote:
> +	if (info.type != BPF_MAP_TYPE_SK_STORAGE) {
> +		fprintf(stderr, "ss: BPF map with ID %s has type '%s', expecting 'sk_storage'\n",
> +			optarg, libbpf_bpf_map_type_str(info.type));
> +		close(fd);
> +		return -1;
> +	}

ss.c: In function ‘bpf_map_opts_load_info’:
ss.c:3448:33: warning: implicit declaration of function
‘libbpf_bpf_map_type_str’ [-Wimplicit-function-declaration]
 3448 |                         optarg, libbpf_bpf_map_type_str(info.type));
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~
ss.c:3447:68: warning: format ‘%s’ expects argument of type ‘char *’,
but argument 4 has type ‘int’ [-Wformat=]
 3447 |                 fprintf(stderr, "ss: BPF map with ID %s has type
'%s', expecting 'sk_storage'\n",
      |                                                                   ~^
      |                                                                    |
      |
  char *
      |                                                                   %d
 3448 |                         optarg, libbpf_bpf_map_type_str(info.type));
      |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                 |
      |                                 int
    CC       lnstat_util.o
    LINK     lnstat
    LINK     ss
/usr/bin/ld: ss.o: in function `main':


Ubuntu 22.04 has libbpf-0.5 installed. I suspect version hook is needed.
e.g., something like this (but with the relevant version numbers):

#if (LIBBPF_MAJOR_VERSION > 0) || (LIBBPF_MINOR_VERSION >= 7)