netdev - [net-next RFC PATCH 0/6] net: phy: support multi PHY in phy_driver Was: net: phy: detach PHY driver OPs from phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240218190034.15447-1-ansuelsmth@gmail.com>
Date: Sun, 18 Feb 2024 20:00:26 +0100
From: Christian Marangi <ansuelsmth@...il.com>
To: Andrew Lunn <andrew@...n.ch>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Christian Marangi <ansuelsmth@...il.com>,
	Robert Marko <robimarko@...il.com>,
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>,
	Nipun Gupta <nipun.gupta@....com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Puneet Gupta <puneet.gupta@....com>,
	Abhijit Gangurde <abhijit.gangurde@....com>,
	Umang Jain <umang.jain@...asonboard.com>,
	netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [net-next RFC PATCH 0/6] net: phy: support multi PHY in phy_driver Was: net: phy: detach PHY driver OPs from phy_driver struct

This is an alternative implementation of "net: phy: detach PHY driver OPs
from phy_driver struct" with the same object in mind.

As was pointed out in the previous series, deatching OPs is a way too big
change (although IMHO needed, but I understand the problem with downstream
and ugly code). As suggested and was already an idea discussed privately,
a more easier approach is introduce an alternative way in phy_driver
struct to declare PHY with the use of an array of IDs.

Some small changes were needed to mod_devicetable to make mdio_device_id
more suitable for the task.

This implementation keep the single way to declare PHY ID in phy_driver
but also indotruce .ids where a table of mdio_device_id can be defined.
Each entry can optionally have a .name variable to define a more specific
PHY name (for phydev_info/err.. usage) that if detected will overwrite
the dev name.

An example of this name is a phy_driver with a .name "Aquantia 107/102"
and .ids with single mdio_device_id with "Aquantia 107" and "Aquantia 102"

"Aquantia 107/102" will be used for early PHY driver probe and the more
specific name will be used as soon as the phydev dev_id is populated.

Aquantia driver is reworked to this implementation and BCM7xxx driver
table is rewritten to greatly benefits from this implementation.

While at it I also notice a strange problem with detected PHY ID and
C45 PHYs. Probably i will have to drop it, but including in this series
just to make someone aware and maybe discuss about it too?

Christian Marangi (6):
  net: phy: add support for defining multiple PHY IDs in PHY driver
  net: phy: fill phy_id with C45 PHY
  mod_devicetable: permit to define a name for an mdio_device_id
  net: phy: support named mdio_device_id PHY IDs
  net: phy: aquantia: group common OPs for PHYs where possible
  net: phy: bcm7xxx: rework phy_driver table to new multiple PHY ID
    format

 drivers/net/phy/aquantia/aquantia_main.c | 170 +++++++++--------------
 drivers/net/phy/bcm7xxx.c                | 140 +++++++++++--------
 drivers/net/phy/phy_device.c             | 104 +++++++++++---
 include/linux/mod_devicetable.h          |   2 +
 include/linux/phy.h                      |   8 +-
 5 files changed, 243 insertions(+), 181 deletions(-)

-- 
2.43.0