netdev - Re: [PATCH net-next v4 05/17] net: pse-pd: Introduce PSE types enumeration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240219160456.0b5e8de3@kmaincent-XPS-13-7390>
Date: Mon, 19 Feb 2024 16:04:56 +0100
From: Köry Maincent <kory.maincent@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet
 <corbet@....net>, Luis Chamberlain <mcgrof@...nel.org>, Russ Weight
 <russ.weight@...ux.dev>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>, Oleksij Rempel <o.rempel@...gutronix.de>, Mark Brown
 <broonie@...nel.org>, Frank Rowand <frowand.list@...il.com>, Andrew Lunn
 <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, devicetree@...r.kernel.org, Dent Project
 <dentproject@...uxfoundation.org>
Subject: Re: [PATCH net-next v4 05/17] net: pse-pd: Introduce PSE types
 enumeration

On Fri, 16 Feb 2024 17:36:38 -0800
Jakub Kicinski <kuba@...nel.org> wrote:
> > > but why the separate header? Is it going to be used in other parts of
> > > uAPI than just in ethtool?    
> > 
> > We might use it in pse core if capabilities between PoE and PoDL differ but
> > I am not sure about it.
> > Do you prefer to move it to ethtool header and add prefix ETHTOOL_ to the
> > enum values?  
> 
> I don't know enough to have an opinion :) Whatever you end up doing,
> it's probably worth documenting the reason for the choice in the commit
> message?

Mmh, I am still not sure of the best choice on this. I think I will move it to
ethtool as you suggested.

> > > > This patch is sponsored by Dent Project
> > > > <dentproject@...uxfoundation.org>      
> > > 
> > > side-note: no objections to the line but for accounting purposes
> > > (i.e. when we generate development stats) we use the Author / From
> > > line exclusively. So it'd be easier to compute stats of things funded
> > > by Dent if you used:
> > > 
> > > From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
> > > 
> > > but that's entirely up to you :)    
> > 
> > Does adding the line side to the SOB in the commit message is sufficient or
> > should I modify the git send email config?  
> 
> I think you can sed -i s/// the patches? When the From in the email
> file doesn't match your git config IIUC git will include the from line
> in the body and pick it up from them. IOW it will work. The scripts look
> at git author so s-o-b won't do much.

Ok, I will stick to the simple sentence then. ;)
Thanks for the information!

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com