netdev - Re: [patch net-next] devlink: fix port dump cmd type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 19 Feb 2024 15:13:43 +0000
From: Simon Horman <horms@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, kuba@...nel.org, pabeni@...hat.com,
	davem@...emloft.net, edumazet@...gle.com
Subject: Re: [patch net-next] devlink: fix port dump cmd type

On Fri, Feb 16, 2024 at 12:31:47PM +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
> 
> Unlike other commands, due to a c&p error, port dump fills-up cmd with
> wrong value, different from port-get request cmd, port-get doit reply
> and port notification.
> 
> Fix it by filling cmd with value DEVLINK_CMD_PORT_NEW.
> 
> Skimmed through devlink userspace implementations, none of them cares
> about this cmd value. Only ynl, for which, this is actually a fix, as it
> expects doit and dumpit ops rsp_value to be the same.

I guess that in theory unknown implementations could exist.
But, ok :)

> 
> Omit the fixes tag, even thought this is fix, better to target this for
> next release.
> 
> Signed-off-by: Jiri Pirko <jiri@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>