netdev - Re: [PATCH net 2/3] tools: ynl: make sure we always pass yarg to mnl_cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b40eab3-0166-42a9-a865-e00393fe98d6@6wind.com>
Date: Mon, 19 Feb 2024 18:18:45 +0100
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 chuck.lever@...cle.com, jiri@...nulli.us, willemb@...gle.com
Subject: Re: [PATCH net 2/3] tools: ynl: make sure we always pass yarg to
 mnl_cb_run

Le 17/02/2024 à 01:17, Jakub Kicinski a écrit :
> There is one common error handler in ynl - ynl_cb_error().
> It expects priv to be a pointer to struct ynl_parse_arg AKA yarg.
> To avoid potential crashes if we encounter a stray NLMSG_ERROR
> always pass yarg as priv (or a struct which has it as the first
> member).
> 
> ynl_cb_null() has a similar problem directly - it expects yarg
> but priv passed by the caller is ys.
> 
> Found by code inspection.
> 
> Fixes: 86878f14d71a ("tools: ynl: user space helpers")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>