netdev - Re: [PATCH] can: raw: fix getsockopt() for new CAN_RAW_XL_VCID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a41ed65c-a916-424d-b4e7-9db65c015b50@hartkopp.net>
Date: Mon, 19 Feb 2024 21:23:00 +0100
From: Oliver Hartkopp <socketcan@...tkopp.net>
To: linux-can@...r.kernel.org
Cc: Marc Kleine-Budde <mkl@...gutronix.de>, netdev@...r.kernel.org,
 Simon Horman <horms@...nel.org>
Subject: Re: [PATCH] can: raw: fix getsockopt() for new CAN_RAW_XL_VCID_OPTS

Sorry. Of course it is a [PATCH net-next] where the referenced commit 
has been applied.

Best regards,
Oliver

On 2024-02-19 21:00, Oliver Hartkopp wrote:
> The code for the CAN_RAW_XL_VCID_OPTS getsockopt() was incompletely adopted
> from the CAN_RAW_FILTER getsockopt().
> 
> Add the missing put_user() and return statements.
> 
> Flagged by Smatch.
> Fixes: c83c22ec1493 ("can: canxl: add virtual CAN network identifier support")
> Reported-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Oliver Hartkopp <socketcan@...tkopp.net>
> ---
>   net/can/raw.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/net/can/raw.c b/net/can/raw.c
> index cb8e6f788af8..897ffc17d850 100644
> --- a/net/can/raw.c
> +++ b/net/can/raw.c
> @@ -833,11 +833,13 @@ static int raw_getsockopt(struct socket *sock, int level, int optname,
>   			if (len > sizeof(ro->raw_vcid_opts))
>   				len = sizeof(ro->raw_vcid_opts);
>   			if (copy_to_user(optval, &ro->raw_vcid_opts, len))
>   				err = -EFAULT;
>   		}
> -		break;
> +		if (!err)
> +			err = put_user(len, optlen);
> +		return err;
>   
>   	case CAN_RAW_JOIN_FILTERS:
>   		if (len > sizeof(int))
>   			len = sizeof(int);
>   		val = &ro->join_filters;