[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240219102224.50cf1010@kmaincent-XPS-13-7390>
Date: Mon, 19 Feb 2024 10:22:24 +0100
From: Köry Maincent <kory.maincent@...tlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
<pabeni@...hat.com>, Jonathan Corbet <corbet@....net>, Luis Chamberlain
<mcgrof@...nel.org>, Russ Weight <russ.weight@...ux.dev>, Greg
Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki"
<rafael@...nel.org>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
Oleksij Rempel <o.rempel@...gutronix.de>, Mark Brown <broonie@...nel.org>,
Frank Rowand <frowand.list@...il.com>, Andrew Lunn <andrew@...n.ch>, Heiner
Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
devicetree@...r.kernel.org, Dent Project <dentproject@...uxfoundation.org>
Subject: Re: [PATCH net-next v4 11/17] dt-bindings: net: pse-pd: Add another
way of describing several PSE PIs
On Sat, 17 Feb 2024 15:01:55 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> > -required:
> > - - "#pse-cells"
> > + pse_pis:
>
> How did this appear here? Underscores are no allowed.
Didn't know that, sorry.
Indeed it is written in the dts-coding-style.rst, sorry for the error.
>
> > + type: object
>
>
> Missing description.
Ah indeed.
> > + items:
> > + enum:
> > + - "alternative-a"
> > + - "alternative-b"
>
> No need for quotes.
Yes I saw that warning with yamllint up to date and have fixed it with for the
next version.
> I believe you did not test it, so I will skip reviewing the rest.
I tested it and did not face any error due to the underscore with
"make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=pse-controller.yaml"
Did I miss something in the test options?
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
Powered by blists - more mailing lists