netdev - Re: [PATCH net] net: stmmac: Fix EST offset for dwmac 5.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mmjrlyzhegve5u3s3lhw4hmhooxixn3pwxkkdikxgxno4teqyz@rtetljwg6ffg>
Date: Tue, 20 Feb 2024 12:20:56 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Kurt Kanzenbach <kurt@...utronix.de>
Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>, 
	Jose Abreu <joabreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Rohan G Thomas <rohan.g.thomas@...el.com>, 
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net] net: stmmac: Fix EST offset for dwmac 5.10

Hi Kurt

On Tue, Feb 20, 2024 at 09:22:46AM +0100, Kurt Kanzenbach wrote:
> Fix EST offset for dwmac 5.10.
> 
> Currently configuring Qbv doesn't work as expected. The schedule is
> configured, but never confirmed:
> 
> |[  128.250219] imx-dwmac 428a0000.ethernet eth1: configured EST
> 
> The reason seems to be the refactoring of the EST code which set the wrong
> EST offset for the dwmac 5.10. After fixing this it works as before:
> 
> |[  106.359577] imx-dwmac 428a0000.ethernet eth1: configured EST
> |[  128.430715] imx-dwmac 428a0000.ethernet eth1: EST: SWOL has been switched
> 
> Tested on imx93.
> 
> Fixes: c3f3b97238f6 ("net: stmmac: Refactor EST implementation")
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
> ---
>  drivers/net/ethernet/stmicro/stmmac/hwif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c
> index 1bd34b2a47e8..29367105df54 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c
> @@ -224,7 +224,7 @@ static const struct stmmac_hwif_entry {
>  		.regs = {
>  			.ptp_off = PTP_GMAC4_OFFSET,
>  			.mmc_off = MMC_GMAC4_OFFSET,
> -			.est_off = EST_XGMAC_OFFSET,
> +			.est_off = EST_GMAC4_OFFSET,

Unfortunate c&p typo indeed. Thanks for fixing it!
Reviewed-by: Serge Semin <fancer.lancer@...il.com>

-Serge(y)

>  		},
>  		.desc = &dwmac4_desc_ops,
>  		.dma = &dwmac410_dma_ops,
> 
> ---
> base-commit: 40b9385dd8e6a0515e1c9cd06a277483556b7286
> change-id: 20240220-stmmac_est-ea6884f9ba3c
> 
> Best regards,
> -- 
> Kurt Kanzenbach <kurt@...utronix.de>
> 
>