[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a52361ef-66ab-41bd-b245-ccd26fcbd957@lunn.ch>
Date: Tue, 20 Feb 2024 15:45:28 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Ariel Elior <aelior@...vell.com>,
Manish Chopra <manishc@...vell.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
Tony Nguyen <anthony.l.nguyen@...el.com>, linux-usb@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH net-next v4 3/9] net: qlogic: qede: Use linkmode helpers
for EEE
> > + unsupp = linkmode_andnot(tmp, edata->advertised, supported);
>
> nit: Given the types involved, I might have written this as:
>
> unsupp = !!linkmode_andnot(tmp, edata->advertised, supported);
linkmode_andnot() calls bitmap_andnot():
static inline bool bitmap_andnot(unsigned long *dst, const unsigned long *src1,
const unsigned long *src2, unsigned int nbits)
It already returns a bool, so there is no need to force an int to bool
conversion using !!.
Andrew
Powered by blists - more mailing lists