netdev - Re: [iwl-net v1 2/2] igb: Fix missing time sync events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877ciz59hi.fsf@intel.com>
Date: Tue, 20 Feb 2024 09:30:33 -0800
From: Vinicius Costa Gomes <vinicius.gomes@...el.com>
To: Richard Cochran <richardcochran@...il.com>
Cc: intel-wired-lan@...ts.osuosl.org, sasha.neftin@...el.com,
 kurt@...utronix.de, anthony.l.nguyen@...el.com,
 jesse.brandeburg@...el.com, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [iwl-net v1 2/2] igb: Fix missing time sync events

Richard Cochran <richardcochran@...il.com> writes:

> On Sat, Feb 17, 2024 at 07:05:07AM -0800, Richard Cochran wrote:
>
>> Does setting ICR.Time_Sync[TXTS] also clear ICR.Time_Sync[RXTS] ?
>> 
>> That is what you seem to be saying.
>
> Okay, so you really mean that if the _same_ bit becomes set between
> the read and the acknowledgment, then that event will be missed,
> right?
>

Yeah, I will reword the commit messages so it's clearer that it's the
same bit.

> In that case, thank you for fixing this more than nine year old bug!
>
> Acked-by: Richard Cochran <richardcochran@...il.com>
>
>  

Thank you,
-- 
Vinicius