netdev - Re: [PATCH net] net: mctp: take ownership of skb in mctp_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c940ae800544aabd92be1fa9e2cd49e3fc50360.camel@codeconstruct.com.au>
Date: Tue, 20 Feb 2024 15:51:52 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, Matt Johnston <matt@...econstruct.com.au>, 
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>
Subject: Re: [PATCH net] net: mctp: take ownership of skb in
 mctp_local_output

Hi Simon,
> Previously this path returned -EINVAL. Now it will return rc.
> But by my reading rc is set to -ENODEV here.
> Should that be addressed?

Yes! While ENODEV is kind-of suitable here, but it would be better to
not change that case. I will send a v2 soon.

Thanks for the review.

Cheers,

Jeremy