netdev - Re: [PATCH stable 5.4 v3] net: bcmgenet: Fix EEE implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024022142-jailer-unburned-2080@gregkh>
Date: Wed, 21 Feb 2024 12:02:50 +0100
From: Greg KH <greg@...ah.com>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: stable@...r.kernel.org, Russell King <rmk+kernel@...linux.org.uk>,
	Jakub Kicinski <kuba@...nel.org>, Doug Berger <opendmb@...il.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	"open list:BROADCOM GENET ETHERNET DRIVER" <bcm-kernel-feedback-list@...adcom.com>,
	"open list:BROADCOM GENET ETHERNET DRIVER" <netdev@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH stable 5.4 v3] net: bcmgenet: Fix EEE implementation

On Sun, Feb 11, 2024 at 05:48:57PM -0800, Florian Fainelli wrote:
> commit a9f31047baca57d47440c879cf259b86f900260c upstream
> 
> We had a number of short comings:
> 
> - EEE must be re-evaluated whenever the state machine detects a link
>   change as wight be switching from a link partner with EEE
>   enabled/disabled
> 
> - tx_lpi_enabled controls whether EEE should be enabled/disabled for the
>   transmit path, which applies to the TBUF block
> 
> - We do not need to forcibly enable EEE upon system resume, as the PHY
>   state machine will trigger a link event that will do that, too
> 
> Fixes: 6ef398ea60d9 ("net: bcmgenet: add EEE support")
> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> Reviewed-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> Link: https://lore.kernel.org/r/20230606214348.2408018-1-florian.fainelli@broadcom.com
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> Changes in v2:
> 
> - removed Changed-id

All now queued up, thanks.

greg k-h