netdev - Re: [PATCH net-next v7 11/11] tcp: get rid of NOT_SPECIFIED reason in tcp_v4/6_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+huvL_Zidru_sNHbjwgM7==-q49+mgJq7vZPRgH6DgKg@mail.gmail.com>
Date: Wed, 21 Feb 2024 15:47:45 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, 
	dsahern@...nel.org, kuniyu@...zon.com, netdev@...r.kernel.org, 
	Jason Xing <kernelxing@...cent.com>
Subject: Re: [PATCH net-next v7 11/11] tcp: get rid of NOT_SPECIFIED reason in tcp_v4/6_do_rcv

On Wed, Feb 21, 2024 at 3:58 AM Jason Xing <kerneljasonxing@...il.com> wrote:
>
> From: Jason Xing <kernelxing@...cent.com>
>
> Finally we can drop this obscure reason in receive path  because
> we replaced with many other more accurate reasons before.


This is not obscure, but the generic reason.

I don't think we can review this patch easily, I would rather squash
it in prior patches.

>
> Signed-off-by: Jason Xing <kernelxing@...cent.com>
> --
> v5:
> 1. change the misspelled word in the title
> ---
>  net/ipv4/tcp_ipv4.c | 1 -
>  net/ipv6/tcp_ipv6.c | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> index c886c671fae9..82e63f6af34b 100644
> --- a/net/ipv4/tcp_ipv4.c
> +++ b/net/ipv4/tcp_ipv4.c
> @@ -1907,7 +1907,6 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
>                 return 0;
>         }
>
> -       reason = SKB_DROP_REASON_NOT_SPECIFIED;
>         if (tcp_checksum_complete(skb))
>                 goto csum_err;
>
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index f260c28e5b18..56c3a3bf1323 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -1623,7 +1623,6 @@ int tcp_v6_do_rcv(struct sock *sk, struct sk_buff *skb)
>         if (np->rxopt.all)
>                 opt_skb = skb_clone_and_charge_r(skb, sk);
>
> -       reason = SKB_DROP_REASON_NOT_SPECIFIED;
>         if (sk->sk_state == TCP_ESTABLISHED) { /* Fast path */
>                 struct dst_entry *dst;
>
> --
> 2.37.3
>