netdev - Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1708481025.1893313-1-xuanzhuo@linux.alibaba.com>
Date: Wed, 21 Feb 2024 10:03:45 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: Halil Pasic <pasic@...ux.ibm.com>
Cc: Jason Wang <jasowang@...hat.com>,
 virtualization@...ts.linux.dev,
 Richard Weinberger <richard@....at>,
 Anton Ivanov <anton.ivanov@...bridgegreys.com>,
 Johannes Berg <johannes@...solutions.net>,
 "Michael S. Tsirkin" <mst@...hat.com>,
 "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Vadim Pasternak <vadimp@...dia.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Mathieu Poirier <mathieu.poirier@...aro.org>,
 Cornelia Huck <cohuck@...hat.com>,
 Eric Farman <farman@...ux.ibm.com>,
 Heiko Carstens <hca@...ux.ibm.com>,
 Vasily Gorbik <gor@...ux.ibm.com>,
 Alexander Gordeev <agordeev@...ux.ibm.com>,
 Christian Borntraeger <borntraeger@...ux.ibm.com>,
 Sven Schnelle <svens@...ux.ibm.com>,
 Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Benjamin Berg <benjamin.berg@...el.com>,
 Yang Li <yang.lee@...ux.alibaba.com>,
 linux-um@...ts.infradead.org,
 netdev@...r.kernel.org,
 platform-driver-x86@...r.kernel.org,
 linux-remoteproc@...r.kernel.org,
 linux-s390@...r.kernel.org,
 kvm@...r.kernel.org,
 bpf@...r.kernel.org,
 Halil Pasic <pasic@...ux.ibm.com>
Subject: Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters

On Tue, 20 Feb 2024 15:18:15 +0100, Halil Pasic <pasic@...ux.ibm.com> wrote:
> On Thu, 1 Feb 2024 11:00:42 +0800
> Xuan Zhuo <xuanzhuo@...ux.alibaba.com> wrote:
>
> > > > And squish the parameters from transport to a structure.
> > >
> > > The patch did more than what is described here, it also switch to use
> > > a structure for vring_create_virtqueue() etc.
> > >
> > > Is it better to split?
> >
> > Sure.
>
> I understand there will be a v2. From virtio-ccw perspective I have
> no objections.

The next version is v1.

That is posted.

http://lore.kernel.org/all/20240202093951.120283-8-xuanzhuo@linux.alibaba.com
http://lore.kernel.org/all/20240202093951.120283-9-xuanzhuo@linux.alibaba.com

Thanks.

>
> Regards,
> Halil