netdev - Re: [net 08/10] net/mlx5e: RSS, Unconfigure RXFH after changing channels number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd5fafee-2cb4-4169-9bf0-6b9b66fb70fc@gmail.com>
Date: Wed, 21 Feb 2024 21:55:18 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, Saeed Mahameed <saeed@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
 Eric Dumazet <edumazet@...gle.com>, Saeed Mahameed <saeedm@...dia.com>,
 netdev@...r.kernel.org, Tariq Toukan <tariqt@...dia.com>,
 Gal Pressman <gal@...dia.com>, Leon Romanovsky <leonro@...dia.com>,
 Carolina Jubran <cjubran@...dia.com>
Subject: Re: [net 08/10] net/mlx5e: RSS, Unconfigure RXFH after changing
 channels number

On 21/02/2024 4:46, Jakub Kicinski wrote:
> On Mon, 19 Feb 2024 19:29:46 -0800 Saeed Mahameed wrote:
>> +	/* Changing the channels number can affect the size of the RXFH indir table.
>> +	 * Therefore, if the RXFH was previously configured,
>> +	 * unconfigure it to ensure that the RXFH is reverted to a uniform table.
>> +	 */
>> +	rxfh_configured = netif_is_rxfh_configured(priv->netdev);
>> +	if (rxfh_configured)
>> +		priv->netdev->priv_flags &= ~IFF_RXFH_CONFIGURED;
> 
> The sole purpose of this flag is to prevent drivers from resetting
> configuration set by the user. The user can:
> 
> 	ethtool -X $ifc default
> 
> if they no longer care.
> 

Thanks Jakub, somehow I missed this ethtool option.
We will definitely send a modified solution.