netdev - RE: [patch net-next v2 0/3] tools: ynl: couple of cmdline enhancements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB508993726E942F2638B1A0C2D6572@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Wed, 21 Feb 2024 22:29:22 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Jiri Pirko <jiri@...nulli.us>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com"
	<pabeni@...hat.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "swarupkotikalapudi@...il.com"
	<swarupkotikalapudi@...il.com>, "donald.hunter@...il.com"
	<donald.hunter@...il.com>, "sdf@...gle.com" <sdf@...gle.com>,
	"lorenzo@...nel.org" <lorenzo@...nel.org>, "alessandromarcolini99@...il.com"
	<alessandromarcolini99@...il.com>
Subject: RE: [patch net-next v2 0/3] tools: ynl: couple of cmdline
 enhancements



> -----Original Message-----
> From: Jiri Pirko <jiri@...nulli.us>
> Sent: Wednesday, February 21, 2024 7:54 AM
> To: netdev@...r.kernel.org
> Cc: kuba@...nel.org; pabeni@...hat.com; davem@...emloft.net;
> edumazet@...gle.com; Keller, Jacob E <jacob.e.keller@...el.com>;
> swarupkotikalapudi@...il.com; donald.hunter@...il.com; sdf@...gle.com;
> lorenzo@...nel.org; alessandromarcolini99@...il.com
> Subject: [patch net-next v2 0/3] tools: ynl: couple of cmdline enhancements
> 
> From: Jiri Pirko <jiri@...dia.com>
> 
> This is part of the original "netlink: specs: devlink: add the rest of
> missing attribute definitions" set which was rejected [1]. These three
> patches enhances the cmdline user comfort, allowing to pass flag
> attribute with bool values and enum names instead of scalars.
> 
> [1] https://lore.kernel.org/all/20240220181004.639af931@kernel.org/
> 

This series looks straight forward to me.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> ---
> v1->v2:
> - only first 3 patches left, the rest it cut out
> - see changelog of individual patches
> 
> Jiri Pirko (3):
>   tools: ynl: allow user to specify flag attr with bool values
>   tools: ynl: process all scalar types encoding in single elif statement
>   tools: ynl: allow user to pass enum string instead of scalar value
> 
>  tools/net/ynl/lib/ynl.py | 39 ++++++++++++++++++++++++++++++---------
>  1 file changed, 30 insertions(+), 9 deletions(-)
> 
> --
> 2.43.2