netdev - Re: [PATCH net-next] net: copy routing table more efficiently in rt_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8afe7956-8f29-49e8-a59f-7e6b4136fa1d@kernel.org>
Date: Tue, 20 Feb 2024 19:44:24 -0700
From: David Ahern <dsahern@...nel.org>
To: Oliver Crumrine <ozlinuxc@...il.com>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: copy routing table more efficiently in
 rt_dst_clone

On 2/18/24 6:35 AM, Oliver Crumrine wrote:
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 16615d107cf0..ebb17c3a0dec 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -1664,22 +1664,8 @@ struct rtable *rt_dst_clone(struct net_device *dev, struct rtable *rt)
>  			   rt->dst.flags);
>  
>  	if (new_rt) {
> +		*new_rt = *rt;

rtable is a container of dst_entry, so this is copying those fields as well.

pw-bot: reject