netdev - RE: [Intel-wired-lan] [PATCH iwl-next v1 2/2] net: intel: implement modern PM ops declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB586564A441B259DC44D1F6498F562@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Thu, 22 Feb 2024 13:05:31 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Simon Horman <horms@...nel.org>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Eric Dumazet
	<edumazet@...gle.com>, "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
	"Brady, Alan" <alan.brady@...el.com>, Jakub Kicinski <kuba@...nel.org>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>, "Paolo
 Abeni" <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1 2/2] net: intel: implement
 modern PM ops declarations

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Simon Horman
> Sent: Monday, February 19, 2024 10:22 AM
> To: Brandeburg, Jesse <jesse.brandeburg@...el.com>
> Cc: netdev@...r.kernel.org; Eric Dumazet <edumazet@...gle.com>; Nguyen,
> Anthony L <anthony.l.nguyen@...el.com>; Brady, Alan
> <alan.brady@...el.com>; Jakub Kicinski <kuba@...nel.org>; intel-wired-
> lan@...ts.osuosl.org; Paolo Abeni <pabeni@...hat.com>; David S. Miller
> <davem@...emloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 2/2] net: intel: implement
> modern PM ops declarations
> 
> On Sat, Feb 10, 2024 at 02:01:09PM -0800, Jesse Brandeburg wrote:
> > Switch the Intel networking drivers to use the new power management
> > ops declaration formats and macros, which allows us to drop
> > __maybe_unused, as well as a bunch of ifdef checking CONFIG_PM.
> >
> > This is safe to do because the compiler drops the unused functions,
> > verified by checking for any of the power management function symbols
> > being present in System.map for a build without CONFIG_PM.
> >
> > If a driver has runtime PM, define the ops with pm_ptr(), and if the
> > driver has Simple PM, use pm_sleep_ptr(), as well as the new versions
> > of the macros for declaring the members of the pm_ops structs.
> >
> > Checked with network-enabled allnoconfig, allyesconfig, allmodconfig
> > on x64_64.
> >
> > Reviewed-by: Alan Brady <alan.brady@...el.com>
> > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> Reviewed-by: Simon Horman <horms@...nel.org>

Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>