netdev - Re: [PATCH net-next 0/3] net/staging: Don't bother filling in ethtool driver version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZddLCZ8D-qe2nOP_@nanopsycho>
Date: Thu, 22 Feb 2024 14:24:25 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: John Garry <john.g.garry@...cle.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, gregkh@...uxfoundation.org,
	netdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	masahiroy@...nel.org
Subject: Re: [PATCH net-next 0/3] net/staging: Don't bother filling in
 ethtool driver version

Thu, Feb 22, 2024 at 10:00:39AM CET, john.g.garry@...cle.com wrote:
>The drivers included in this series set the ethtool driver version to the
>same as the default, UTS_RELEASE, so don't both doing this.
>
>As noted by Masahiro in [0], with CONFIG_MODVERSIONS=y, some drivers could
>be built as modules against a different kernel tree with differing
>UTS_RELEASE. As such, these changes could lead to a change in behaviour.
>However, defaulting to the core kernel UTS_RELEASE would be expected
>behaviour.
>
>These patches are for netdev and staging trees, and I hope that the
>respective maintainers can pick up the patches separately.
>
>[0] https://lore.kernel.org/all/CAK7LNASfTW+OMk1cJJWb4E6P+=k0FEsm_=6FDfDF_mTrxJCSMQ@mail.gmail.com/
>
>John Garry (3):
>  rocker: Don't bother filling in ethtool driver version
>  net: team: Don't bother filling in ethtool driver version
>  staging: octeon: Don't bother filling in ethtool driver version
>
> drivers/net/ethernet/rocker/rocker_main.c | 2 --
> drivers/net/team/team.c                   | 2 --
> drivers/staging/octeon/ethernet-mdio.c    | 2 --
> 3 files changed, 6 deletions(-)

The set looks fine to me.

Reviewed-by: Jiri Pirko <jiri@...dia.com>