netdev - Re: [PATCH net ver.2] genetlink: fix possible use-after-free and null-ptr-deref in genl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240221172309.405cc4b1@kernel.org>
Date: Wed, 21 Feb 2024 17:23:09 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: kovalev@...linux.org
Cc: netdev@...r.kernel.org, pabeni@...hat.com, davem@...emloft.net,
 edumazet@...gle.com, jiri@...nulli.us, jacob.e.keller@...el.com,
 johannes@...solutions.net, idosch@...dia.com, horms@...nel.org,
 david.lebrun@...ouvain.be, pablo@...filter.org
Subject: Re: [PATCH net ver.2] genetlink: fix possible use-after-free and
 null-ptr-deref in genl_dumpit()

On Tue, 20 Feb 2024 13:25:12 +0300 kovalev@...linux.org wrote:
> From: Vasiliy Kovalev <kovalev@...linux.org>
> 
> The pernet operations structure for the subsystem must be registered
> before registering the generic netlink family.

I think this one is incorrect, genetlink is what other families
register _with_. It's special. Until it opens the socket in
genl_pernet_init() nothing can reach it from user space.

We should probably add a comment saying that it's special, I get
the feeling other families ended up doing a copy & paste of genetlink..
-- 
pw-bot: cr