netdev - Re: [PATCH net-next v2 4/4] dt-bindings: net: cdns,macb: Deprecate magic-packet property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240222175918.GA3500038-robh@kernel.org>
Date: Thu, 22 Feb 2024 10:59:18 -0700
From: Rob Herring <robh@...nel.org>
To: Vineeth Karumanchi <vineeth.karumanchi@....com>
Cc: nicolas.ferre@...rochip.com, claudiu.beznea@...on.dev,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, linux@...linux.org.uk,
	vadim.fedorenko@...ux.dev, andrew@...n.ch, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	git@....com
Subject: Re: [PATCH net-next v2 4/4] dt-bindings: net: cdns,macb: Deprecate
 magic-packet property

On Thu, Feb 22, 2024 at 09:08:48PM +0530, Vineeth Karumanchi wrote:
> WOL modes such as magic-packet should be an OS policy.
> Leverage MACB_CAPS_WOL on supported devices to advertise
> supported modes through ethtool. Use ethtool to activate
> the required mode.

According to the description of the property, it indicates whether magic 
packet is supported by the h/w or not. Enabling WOL or not is a separate 
matter. OTOH, I would think WOL support would be implied by compatible 
properties. No objection from me, just highlighting the distinction.

> 
> Suggested-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@....com>
> ---
>  Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index bf8894a0257e..096309bf3235 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -141,6 +141,7 @@ patternProperties:
>  
>        magic-packet:
>          type: boolean
> +        deprecated: true
>          description:
>            Indicates that the hardware supports waking up via magic packet.
>  
> -- 
> 2.34.1
>