lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <34ee3b60-3560-4e22-be79-b191e7b9e91d@broadcom.com>
Date: Thu, 22 Feb 2024 13:56:45 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Justin Chen <justin.chen@...adcom.com>, netdev@...r.kernel.org
Cc: bcm-kernel-feedback-list@...adcom.com, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, opendmb@...il.com,
 andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
 rafal@...ecki.pl, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next 6/6] net: bcmasp: Add support for PHY interrupts

On 2/22/24 12:56, Justin Chen wrote:
> Hook up the phy interrupts for internal phys to reduce mdio traffic
> and improve responsiveness of link changes.
> 
> Signed-off-by: Justin Chen <justin.chen@...adcom.com>

Acked-by: Florian Fainelli <florian.fainelli@...adcom.com>

One note below:


> +
> +		if (intf->internal_phy)
> +			dev->phydev->irq = PHY_MAC_INTERRUPT;

There will be a trivial conflict here due to 
5b76d928f8b779a1b19c5842e7cabee4cbb610c3 ("net: bcmasp: Indicate MAC is 
in charge of PHY PM")
-- 
Florian


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ