netdev - Re: [PATCH net-next v2 4/4] net: pcs: xpcs: Explicitly return error on caps validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240223105626.71b2bcb2@device-28.home>
Date: Fri, 23 Feb 2024 10:56:26 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Serge Semin <fancer.lancer@...il.com>
Cc: Jose Abreu <joabreu@...opsys.com>, Jose Abreu <Jose.Abreu@...opsys.com>,
 Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, Jakub Kicinski <kuba@...nel.org>,
 Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Mengyuan Lou <mengyuanlou@...-swift.com>, Tomer Maimon
 <tmaimon77@...il.com>, Jiawen Wu <jiawenwu@...stnetic.com>, Alexandre
 Torgue <alexandre.torgue@...s.st.com>, openbmc@...ts.ozlabs.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 4/4] net: pcs: xpcs: Explicitly return error
 on caps validation

Hello Serge,

On Thu, 22 Feb 2024 20:58:23 +0300
Serge Semin <fancer.lancer@...il.com> wrote:

> If an unsupported interface is passed to the PCS validation callback there
> is no need in further link-modes calculations since the resultant array
> will be initialized with zeros which will be perceived by the phylink
> subsystem as error anyway (see phylink_validate_mac_and_pcs()). Instead
> let's explicitly return the -EINVAL error to inform the caller about the
> unsupported interface as it's done in the rest of the pcs_validate
> callbacks.
> 
> Signed-off-by: Serge Semin <fancer.lancer@...il.com>

This looks good to me,

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>