netdev - Re: [RFC]: raw packet filtering via tc-flower

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <375ff6ca-4155-bfd9-24f2-bd6a2171f6bf@gmail.com>
Date: Fri, 23 Feb 2024 12:36:16 +0000
From: Edward Cree <ecree.xilinx@...il.com>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Ahmed Zaki <ahmed.zaki@...el.com>, stephen@...workplumber.org,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, corbet@....net,
 jhs@...atatu.com, xiyou.wangcong@...il.com, netdev@...r.kernel.org,
 "Chittim, Madhu" <madhu.chittim@...el.com>,
 "Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
 amritha.nambiar@...el.com, Jan Sokolowski <jan.sokolowski@...el.com>,
 Jakub Kicinski <kuba@...nel.org>
Subject: Re: [RFC]: raw packet filtering via tc-flower

On 23/02/2024 12:22, Jiri Pirko wrote:
> Nope, the extension of dissector would be clean, one timer. Just add
> support for offset+len based dissection.

... until someone else comes along with another kind of filtering and
 wants _that_ in flower for the same reasons.

>> How about a new classifier that just does this raw matching?
> 
> That's u32 basically, isn't it?

Well, u32 has all the extra complications around hashtables, links,
 permoff... I guess you could have helpers in the kernel to stitch
 'const' u32 filters into raw matches for drivers that only offload
 that and reject anything else; and tc userspace could have syntactic
 sugar to transform Ahmed's offset/pattern/mask into the appropriate
 u32 matches under the hood.