netdev - Re: [PATCH v2 net-next 05/14] netlink: fix netlink_diag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2a5nrs6pt.fsf@gmail.com>
Date: Fri, 23 Feb 2024 12:30:54 +0000
From: Donald Hunter <donald.hunter@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,  Jakub Kicinski
 <kuba@...nel.org>,  Paolo Abeni <pabeni@...hat.com>,
  netdev@...r.kernel.org,  Ido Schimmel <idosch@...dia.com>,  Jiri Pirko
 <jiri@...dia.com>,  eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 05/14] netlink: fix netlink_diag_dump()
 return value

Eric Dumazet <edumazet@...gle.com> writes:

> __netlink_diag_dump() returns 1 if the dump is not complete,
> zero if no error occurred.
>
> If err variable is zero, this means the dump is complete:
> We should not return skb->len in this case, but 0.
>
> This allows NLMSG_DONE to be appended to the skb.
> User space does not have to call us again only to get NLMSG_DONE.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Donald Hunter <donald.hunter@...il.com>