netdev - Re: [RFC net-next 1/3] netdev: add per-queue statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67d36c7b-bd0e-490d-a058-e4d8c8596f9e@intel.com>
Date: Fri, 23 Feb 2024 12:40:07 -0800
From: "Nambiar, Amritha" <amritha.nambiar@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <danielj@...dia.com>, <mst@...hat.com>,
	<michael.chan@...adcom.com>
Subject: Re: [RFC net-next 1/3] netdev: add per-queue statistics

On 2/22/2024 5:37 PM, Jakub Kicinski wrote:
> On Thu, 22 Feb 2024 16:23:57 -0800 Nambiar, Amritha wrote:
>>> +int netdev_nl_stats_get_dumpit(struct sk_buff *skb,
>>> +			       struct netlink_callback *cb)
>>> +{
>>> +	struct netdev_nl_dump_ctx *ctx = netdev_dump_ctx(cb);
>>> +	const struct genl_info *info = genl_info_dump(cb);
>>> +	enum netdev_stats_projection projection;
>>> +	struct net *net = sock_net(skb->sk);
>>> +	struct net_device *netdev;
>>> +	int err = 0;
>>> +
>>> +	projection = NETDEV_STATS_PROJECTION_NETDEV;
>>> +	if (info->attrs[NETDEV_A_STATS_PROJECTION])
>>> +		projection =
>>> +			nla_get_uint(info->attrs[NETDEV_A_STATS_PROJECTION]);
>>> +
>>> +	rtnl_lock();
>>
>> Could we also add filtered-dump for a user provided ifindex ?
> 
> Definitely, wasn't sure if that's a pre-requisite for merging,
> or we can leave it on the "netdev ToDo sheet" as a learning task
> for someone. Opinions welcome..

Totally! Ignore the nit-pick.