netdev - Re: [PATCH net-next v6 5/5] selftests/net: Adding test cases of replacing routes and route advertisements.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240222195224.7ff5c5e0@kernel.org>
Date: Thu, 22 Feb 2024 19:52:24 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: thinker.li@...il.com
Cc: netdev@...r.kernel.org, ast@...nel.org, martin.lau@...ux.dev,
 kernel-team@...a.com, davem@...emloft.net, dsahern@...nel.org,
 edumazet@...gle.com, pabeni@...hat.com, liuhangbin@...il.com,
 sinquersw@...il.com, kuifeng@...a.com
Subject: Re: [PATCH net-next v6 5/5] selftests/net: Adding test cases of
 replacing routes and route advertisements.

On Thu,  8 Feb 2024 14:06:53 -0800 thinker.li@...il.com wrote:
>  	# Permanent routes
> -	for i in $(seq 1 5000); do
> +	for i in $(seq 1 5); do
>  	    $IP -6 route add 2001:30::$i \
>  		via 2001:10::2 dev dummy_10
>  	done
>  	# Temporary routes
> -	for i in $(seq 1 1000); do
> +	for i in $(seq 1 5); do
>  	    # Expire route after $EXPIRE seconds
>  	    $IP -6 route add 2001:20::$i \
>  		via 2001:10::2 dev dummy_10 expires $EXPIRE
>  	done
> -	sleep $(($EXPIRE * 2))
> -	N_EXP_SLEEP=$($IP -6 route list |grep expires|wc -l)
> -	if [ $N_EXP_SLEEP -ne 0 ]; then
> -	    echo "FAIL: expected 0 routes with expires," \
> -		 "got $N_EXP_SLEEP (5000 permanent routes)"
> -	    ret=1
> -	else
> -	    ret=0
> +	sleep $(($EXPIRE * 2 + 1))
> +	check_rt_num 0 $($IP -6 route list |grep expires|wc -l)
> +	log_test $ret 0 "ipv6 route garbage collection (with permanent routes)"

Looks like fib_tests.sh have gotten flaky since this got merged :(

https://netdev.bots.linux.dev/contest.html?test=fib-tests-sh&executor=vmksft-net&pass=0

# Fib6 garbage collection test
#     TEST: ipv6 route garbage collection                                 [ OK ]
# FAIL: Expected 0 routes, got 1
#     TEST: ipv6 route garbage collection (with permanent routes)         [FAIL]
#     TEST: ipv6 route garbage collection (replace with expires)          [ OK ]
#     TEST: ipv6 route garbage collection (replace with permanent)        [ OK ]
https://netdev-3.bots.linux.dev/vmksft-net/results/477081/6-fib-tests-sh/stdout

# Fib6 garbage collection test
#     TEST: ipv6 route garbage collection                                 [ OK ]
# FAIL: Expected 0 routes, got 3
#     TEST: ipv6 route garbage collection (with permanent routes)         [FAIL]
#     TEST: ipv6 route garbage collection (replace with expires)          [ OK ]
#     TEST: ipv6 route garbage collection (replace with permanent)        [ OK ]
https://netdev-3.bots.linux.dev/vmksft-net/results/467181/6-fib-tests-sh/stdout

# Fib6 garbage collection test
#     TEST: ipv6 route garbage collection                                 [ OK ]
# FAIL: Expected 0 routes, got 3
#     TEST: ipv6 route garbage collection (with permanent routes)         [FAIL]
#     TEST: ipv6 route garbage collection (replace with expires)          [ OK ]
#     TEST: ipv6 route garbage collection (replace with permanent)        [ OK ]
https://netdev-3.bots.linux.dev/vmksft-net/results/466641/18-fib-tests-sh/stdout

Could you take a look?