[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240222173703.08c442e9@kernel.org>
Date: Thu, 22 Feb 2024 17:37:03 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Nambiar, Amritha" <amritha.nambiar@...el.com>
Cc: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
<pabeni@...hat.com>, <danielj@...dia.com>, <mst@...hat.com>,
<michael.chan@...adcom.com>
Subject: Re: [RFC net-next 1/3] netdev: add per-queue statistics
On Thu, 22 Feb 2024 16:23:57 -0800 Nambiar, Amritha wrote:
> > +int netdev_nl_stats_get_dumpit(struct sk_buff *skb,
> > + struct netlink_callback *cb)
> > +{
> > + struct netdev_nl_dump_ctx *ctx = netdev_dump_ctx(cb);
> > + const struct genl_info *info = genl_info_dump(cb);
> > + enum netdev_stats_projection projection;
> > + struct net *net = sock_net(skb->sk);
> > + struct net_device *netdev;
> > + int err = 0;
> > +
> > + projection = NETDEV_STATS_PROJECTION_NETDEV;
> > + if (info->attrs[NETDEV_A_STATS_PROJECTION])
> > + projection =
> > + nla_get_uint(info->attrs[NETDEV_A_STATS_PROJECTION]);
> > +
> > + rtnl_lock();
>
> Could we also add filtered-dump for a user provided ifindex ?
Definitely, wasn't sure if that's a pre-requisite for merging,
or we can leave it on the "netdev ToDo sheet" as a learning task
for someone. Opinions welcome..
Powered by blists - more mailing lists