netdev - Re: [PATCH net-next 2/2] net: geneve: enable local address bind for geneve sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240224110622.4855a202@griffin>
Date: Sat, 24 Feb 2024 11:06:22 +0100
From: Jiri Benc <jbenc@...hat.com>
To: Richard Gobert <richardbgobert@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, idosch@...dia.com, razor@...ckwall.org,
 amcohen@...dia.com, petrm@...dia.com, b.galvani@...il.com,
 bpoirier@...dia.com, gavinl@...dia.com, martin.lau@...nel.org,
 daniel@...earbox.net, herbert@...dor.apana.org.au, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: geneve: enable local address bind for
 geneve sockets

On Thu, 22 Feb 2024 21:53:50 +0100, Richard Gobert wrote:
>  static const struct nla_policy geneve_policy[IFLA_GENEVE_MAX + 1] = {
> -	[IFLA_GENEVE_UNSPEC]		= { .strict_start_type = IFLA_GENEVE_INNER_PROTO_INHERIT },
> +	[IFLA_GENEVE_UNSPEC]		= { .strict_start_type = IFLA_GENEVE_LOCAL6 },

The strict_start_type value should stay at
IFLA_GENEVE_INNER_PROTO_INHERIT. We don't want to relax the strict
checking for that attribute and we want strict checking for the newly
added IFLA_GENEVE_LOCAL.

See the documentation in include/net/netlink.h.

 Jiri