netdev - Re: [PATCH v2 net] dpll: rely on rcu for netdev_dpll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdnkgctN0wQrQCLR@nanopsycho>
Date: Sat, 24 Feb 2024 13:43:45 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com,
	Jiri Pirko <jiri@...dia.com>,
	Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>,
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Subject: Re: [PATCH v2 net] dpll: rely on rcu for netdev_dpll_pin()

Fri, Feb 23, 2024 at 01:32:08PM CET, edumazet@...gle.com wrote:
>This fixes a possible UAF in if_nlmsg_size(),
>which can run without RTNL.
>
>Add rcu protection to "struct dpll_pin"
>
>Move netdev_dpll_pin() from netdevice.h to dpll.h to
>decrease name pollution.
>
>Note: This looks possible to no longer acquire RTNL in
>netdev_dpll_pin_assign() later in net-next.
>
>v2: do not force rcu_read_lock() in rtnl_dpll_pin_size() (Jiri Pirko)
>
>Fixes: 5f1842692880 ("netdev: expose DPLL pin handle for netdevice")
>Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>

Thanks!