netdev - Re: [PATCH net 1/2] net: veth: clear GRO when clearing XDP even when down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <170894763070.4235.7396075348697529173.git-patchwork-notify@kernel.org>
Date: Mon, 26 Feb 2024 11:40:30 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, lorenzo@...nel.org, toke@...hat.com, tglx@...utronix.de,
 syzbot+039399a9b96297ddedca@...kaller.appspotmail.com
Subject: Re: [PATCH net 1/2] net: veth: clear GRO when clearing XDP even when down

Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Wed, 21 Feb 2024 15:12:10 -0800 you wrote:
> veth sets NETIF_F_GRO automatically when XDP is enabled,
> because both features use the same NAPI machinery.
> 
> The logic to clear NETIF_F_GRO sits in veth_disable_xdp() which
> is called both on ndo_stop and when XDP is turned off.
> To avoid the flag from being cleared when the device is brought
> down, the clearing is skipped when IFF_UP is not set.
> Bringing the device down should indeed not modify its features.
> 
> [...]

Here is the summary with links:
  - [net,1/2] net: veth: clear GRO when clearing XDP even when down
    https://git.kernel.org/netdev/net/c/fe9f801355f0
  - [net,2/2] selftests: net: veth: test syncing GRO and XDP state while device is down
    https://git.kernel.org/netdev/net/c/1a825e4cdf45

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html