netdev - Re: [PATCH net-next] net: dsa: mv88e6xxx: add Amethyst specific SMI GPIO function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb5c185f-1946-4548-9918-01548e9dd9cf@lunn.ch>
Date: Mon, 26 Feb 2024 14:57:27 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Robert Marko <robimarko@...il.com>
Cc: f.fainelli@...il.com, olteanv@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: add Amethyst specific SMI
 GPIO function

On Sat, Feb 24, 2024 at 09:33:09PM +0100, Robert Marko wrote:
> The existing mv88e6xxx_g2_scratch_gpio_set_smi() cannot be used on the
> 88E6393X as it requires certain P0_MODE, it also checks the CPU mode
> as it impacts the bit setting value.
> 
> This is all irrelevant for Amethyst (MV88E6191X/6193X/6393X) as only
> the default value of the SMI_PHY Config bit is set to CPU_MGD bootstrap
> pin value but it can be changed without restrictions so that GPIO pins
> 9 and 10 are used as SMI pins.
> 
> So, introduce Amethyst specific function and call that if the Amethyst
> family wants to setup the external PHY.

This looks good. The only comment i have is maybe we should rename
mv88e6xxx_g2_scratch_gpio_set_smi() to something more specific. It
seems it is only applicable to MV88E6XXX_FAMILY_6390, so maybe
mv88e6390_g2_scratch_gpio_set_smi()?

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew