netdev - Re: [PATCH] net: phy: dp83826: disable WOL at init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0fca6571-39ee-47de-94bc-1bf9749192b1@lunn.ch>
Date: Mon, 26 Feb 2024 16:44:04 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Catalin Popescu <catalin.popescu@...ca-geosystems.com>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	bsp-development.geo@...ca-geosystems.com, m.felsch@...gutronix.de
Subject: Re: [PATCH] net: phy: dp83826: disable WOL at init

On Fri, Feb 23, 2024 at 03:31:27PM +0100, Catalin Popescu wrote:
> Commit d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning")
> introduced a regression in that WOL is not disabled by default for DP83826.
> WOL should normally be enabled through ethtool.
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@...ca-geosystems.com>

d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning") is
only in net-next? So you should set the patch subject to
net-next. See:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq

Please also add a Fixes tag.

The change itself looks O.K.

       Andrew