netdev - Re: [PATCH 0/8] introduce sysctl SYSCTL_U8_MAX and SYSCTL_LONG_S32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240226072814.1d9ab85f@kernel.org>
Date: Mon, 26 Feb 2024 07:28:14 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: wenyang.linux@...mail.com
Cc: Luis Chamberlain <mcgrof@...nel.org>, Kees Cook <keescook@...omium.org>,
 Joel Granados <j.granados@...sung.com>, Christian Brauner
 <brauner@...nel.org>, davem@...emloft.net, David Ahern
 <dsahern@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] introduce sysctl SYSCTL_U8_MAX and
 SYSCTL_LONG_S32_MAX

On Sun, 25 Feb 2024 12:05:30 +0800 wenyang.linux@...mail.com wrote:
> The boundary check of multiple modules uses these static variables (such as
> two_five_five, n_65535, ue_int_max, etc), and they are also not changed.
> Therefore, add them to the shared sysctl_vals and sysctl_long_vals to avoid
> duplication. This also reduce the size a bit 

You provide no data on how big the reduction is.
Eric's suggestion to encode the values directly in the table entry
sounds great, please invest your time in that, instead of half measures.