lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b6c74bbe-89f0-4201-b968-57996f0e0223@broadcom.com>
Date: Mon, 26 Feb 2024 11:42:09 -0800
From: Justin Chen <justin.chen@...adcom.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 netdev@...r.kernel.org
Cc: bcm-kernel-feedback-list@...adcom.com, florian.fainelli@...adcom.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 conor+dt@...nel.org, opendmb@...il.com, andrew@...n.ch,
 hkallweit1@...il.com, linux@...linux.org.uk, rafal@...ecki.pl,
 devicetree@...r.kernel.org
Subject: Re: [PATCH net-next resend 2/6] dt-bindings: net: brcm,asp-v2.0: Add
 asp-v2.2



On 2/24/24 2:22 AM, Krzysztof Kozlowski wrote:
> On 23/02/2024 23:24, Justin Chen wrote:
>> Add support for ASP 2.2.
>>
>> Signed-off-by: Justin Chen <justin.chen@...adcom.com>
>> ---
>>   Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>> index 75d8138298fb..5a345f03de17 100644
>> --- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>> +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>> @@ -15,6 +15,10 @@ description: Broadcom Ethernet controller first introduced with 72165
>>   properties:
>>     compatible:
>>       oneOf:
>> +      - items:
>> +          - enum:
>> +              - brcm,bcm74165-asp
>> +          - const: brcm,asp-v2.2
>>         - items:
>>             - enum:
>>                 - brcm,bcm74165-asp
> 
> Hm, this confuses me: why do you have same SoC with three different
> versions of the same block?
> 

bcm72165 -> asp-v2.0
bcm74165 -> asp-v2.1
Are two different SoCs.

The entry I just added is
bcm74165 -> asp-v2.2
This is a SoC minor revision. Maybe it should bcm74165b0-asp instead? 
Not sure what the protocol is.

Thanks,
Justin

> Best regards,
> Krzysztof
> 

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4206 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ