netdev - Re: [PATCH] net: ieee802154: mcr20a: convert to use maple tree register cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc64b713-0e38-4674-8d8e-54389c22d95c@datenfreihafen.org>
Date: Mon, 26 Feb 2024 21:50:38 +0100
From: Stefan Schmidt <stefan@...enfreihafen.org>
To: Bo Liu <liubo03@...pur.com>, alex.aring@...il.com,
 miquel.raynal@...tlin.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com
Cc: linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ieee802154: mcr20a: convert to use maple tree
 register cache

Hello,

On 02.02.24 07:46, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Bo Liu <liubo03@...pur.com>
> ---
>   drivers/net/ieee802154/mcr20a.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
> index 87abe3b46316..efb1be3c644e 100644
> --- a/drivers/net/ieee802154/mcr20a.c
> +++ b/drivers/net/ieee802154/mcr20a.c
> @@ -251,7 +251,7 @@ static const struct regmap_config mcr20a_dar_regmap = {
>   	.val_bits		= 8,
>   	.write_flag_mask	= REGISTER_ACCESS | REGISTER_WRITE,
>   	.read_flag_mask		= REGISTER_ACCESS | REGISTER_READ,
> -	.cache_type		= REGCACHE_RBTREE,
> +	.cache_type		= REGCACHE_MAPLE,
>   	.writeable_reg		= mcr20a_dar_writeable,
>   	.readable_reg		= mcr20a_dar_readable,
>   	.volatile_reg		= mcr20a_dar_volatile,
> @@ -387,7 +387,7 @@ static const struct regmap_config mcr20a_iar_regmap = {
>   	.val_bits		= 8,
>   	.write_flag_mask	= REGISTER_ACCESS | REGISTER_WRITE | IAR_INDEX,
>   	.read_flag_mask		= REGISTER_ACCESS | REGISTER_READ  | IAR_INDEX,
> -	.cache_type		= REGCACHE_RBTREE,
> +	.cache_type		= REGCACHE_MAPLE,
>   	.writeable_reg		= mcr20a_iar_writeable,
>   	.readable_reg		= mcr20a_iar_readable,
>   	.volatile_reg		= mcr20a_iar_volatile,

This patch has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt