[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGrbwDTDfkwf40cTkXh6QgQwPpsAVVLWENYH=_eko5tHCKC5VQ@mail.gmail.com>
Date: Mon, 26 Feb 2024 23:51:49 +0000
From: Dmitry Safonov <dima@...sta.com>
To: Simon Horman <horms@...nel.org>
Cc: Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>,
Shuah Khan <shuah@...nel.org>, Steven Rostedt <rostedt@...dmis.org>,
Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-kselftest@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
Dmitry Safonov <0x7f454c46@...il.com>
Subject: Re: [PATCH net-next 03/10] net/tcp: Move tcp_inbound_hash() from headers
On Mon, Feb 26, 2024 at 8:43 PM Simon Horman <horms@...nel.org> wrote:
>
> On Sat, Feb 24, 2024 at 09:04:11AM +0000, Dmitry Safonov wrote:
[..]
> > + if (req) {
> > + if (tcp_rsk_used_ao(req) != !!aoh) {
> > + u8 keyid, rnext, maclen;
> > +
> > + if (aoh) {
> > + keyid = aoh->keyid;
> > + rnext = aoh->rnext_keyid;
> > + maclen = tcp_ao_hdr_maclen(aoh);
> > + } else {
> > + keyid = rnext = maclen = 0;
> > + }
>
> Hi Dmitry,
>
> it looks like keyid is set but otherwise unused.
>
> Flagged by W=1 builds with gcc-13 and clang-17.
Hi Simon,
Yeah, I think I didn't notice it when I was splitting the WIP patch.
It should be in the very next patch that uses them:
+ trace_tcp_ao_handshake_failure(sk, skb, keyid,
rnext, maclen);
Thanks for the report, going to fix in v2,
Dmitry
Powered by blists - more mailing lists