netdev - Re: [PATCH net-next] ipv6: anycast: complete RCU handling of struct ifacaddr6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZdxXxLOfYjeQwy_R@nanopsycho>
Date: Mon, 26 Feb 2024 10:20:04 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next] ipv6: anycast: complete RCU handling of struct
 ifacaddr6

Fri, Feb 23, 2024 at 09:10:54PM CET, edumazet@...gle.com wrote:
>struct ifacaddr6 are already freed after RCU grace period.
>
>Add __rcu qualifier to aca_next pointer, and idev->ac_list
>
>Add relevant rcu_assign_pointer() and dereference accessors.
>
>ipv6_chk_acast_dev() no longer needs to acquire idev->lock.
>
>/proc/net/anycast6 is now purely RCU protected, it no
>longer acquires idev->lock.
>
>Similarly in6_dump_addrs() can use RCU protection to iterate
>through anycast addresses. It was relying on a mixture of RCU
>and RTNL but next patches will get rid of RTNL there.
>
>Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>