netdev - Re: [PATCH net 1/2] net: dsa: mv88e6xxx: fix marvell 6320/21 switch probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zdxah+wBafeTHzQ0@shell.armlinux.org.uk>
Date: Mon, 26 Feb 2024 09:31:51 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Steffen Bätz <steffen@...osonix.de>
Cc: Fabio Estevam <festevam@...il.com>, Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/2] net: dsa: mv88e6xxx: fix marvell 6320/21 switch
 probing

On Mon, Feb 26, 2024 at 10:13:23AM +0100, Steffen Bätz wrote:
> @@ -649,6 +649,19 @@ static void mv88e6352_phylink_get_caps(struct mv88e6xxx_chip *chip, int port,
>  	}
>  }
>  
> +static void mv88e632x_phylink_get_caps(struct mv88e6xxx_chip *chip, int port,
> +				       struct phylink_config *config)
> +{
> +	unsigned long *supported = config->supported_interfaces;
> +	int err, cmode;
> +
> +	/* Translate the default cmode */
> +	mv88e6xxx_translate_cmode(chip->ports[port].cmode, supported);
> +
> +	config->mac_capabilities = MAC_SYM_PAUSE | MAC_10 | MAC_100 |
> +				   MAC_1000FD;
> +}
> +

This looks identical to mv88e6351_phylink_get_caps(). Would that work
for you instead?

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!