netdev - Re: [PATCH net-next 00/15] tools: ynl: stop using libmnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m27ciroaur.fsf@gmail.com>
Date: Mon, 26 Feb 2024 09:04:12 +0000
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net,  netdev@...r.kernel.org,  edumazet@...gle.com,
  pabeni@...hat.com,  jiri@...nulli.us,  sdf@...gle.com,
  nicolas.dichtel@...nd.com
Subject: Re: [PATCH net-next 00/15] tools: ynl: stop using libmnl

Jakub Kicinski <kuba@...nel.org> writes:

> On Fri, 23 Feb 2024 16:26:33 +0000 Donald Hunter wrote:
>> Is the absence of buffer bounds checking intentional, i.e. relying on libasan?
>
> In ynl.c or the generated code?

I'm looking at ynl_attr_nest_start() and ynl_attr_put*() in ynl-priv.h
and there's no checks for buffer overrun. It is admittedly a big
buffer, with rx following tx, but still.