netdev - Re: [net-next PatchV2] octeontx2-pf: Add support to read eeprom information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240226170027.6a43f196@kernel.org>
Date: Mon, 26 Feb 2024 17:00:27 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Hariprasad Kelam <hkelam@...vell.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <pabeni@...hat.com>, <edumazet@...gle.com>, <davem@...emloft.net>,
 <sbhatta@...vell.com>, <gakula@...vell.com>, <sgoutham@...vell.com>
Subject: Re: [net-next PatchV2] octeontx2-pf: Add support to read eeprom
 information

On Thu, 22 Feb 2024 22:45:42 +0530 Hariprasad Kelam wrote:
> +	if (!ee->len || ((ee->len + ee->offset) > SFP_EEPROM_SIZE))
> +		return -EINVAL;

Are you sure there's a path thru the core to the driver which would
allow len == 0 or the size being larger than when info put in
eeprom_len?
-- 
pw-bot: cr