netdev - Re: [PATCH net-next 3/3] inet: use xa_array iterator to implement inet_netconf_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zd3epaTHEllJIeRO@nanopsycho>
Date: Tue, 27 Feb 2024 14:07:49 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	David Ahern <dsahern@...nel.org>, Jiri Pirko <jiri@...dia.com>,
	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 3/3] inet: use xa_array iterator to implement
 inet_netconf_dump_devconf()

Tue, Feb 27, 2024 at 10:24:11AM CET, edumazet@...gle.com wrote:
>1) inet_netconf_dump_devconf() can run under RCU protection
>   instead of RTNL.
>
>2) properly return 0 at the end of a dump, avoiding an
>   an extra recvmsg() system call.
>
>3) Do not use inet_base_seq() anymore, for_each_netdev_dump()
>   has nice properties. Restarting a GETDEVCONF dump if a device has
>   been added/removed or if net->ipv4.dev_addr_genid has changed is moot.
>
>Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Jiri Pirko <jiri@...dia.com>