netdev - Re: [PATCH net-next 1/3] netdev: add per-queue statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6dcf163a-c089-4047-a3d7-ee492778db48@intel.com>
Date: Tue, 27 Feb 2024 17:17:38 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <amritha.nambiar@...el.com>, <danielj@...dia.com>,
	<mst@...hat.com>, <michael.chan@...adcom.com>, <sdf@...gle.com>,
	<vadim.fedorenko@...ux.dev>
Subject: Re: [PATCH net-next 1/3] netdev: add per-queue statistics

On 2/27/24 16:00, Jakub Kicinski wrote:
> On Tue, 27 Feb 2024 11:29:02 +0100 Przemek Kitszel wrote:
>>> + * Device drivers are encouraged to reset the per-queue statistics when
>>> + * number of queues change. This is because the primary use case for
>>> + * per-queue statistics is currently to detect traffic imbalance.
>>
>> I get it, but encouraging users to reset those on queue-count-change
>> seems to cover that case too. I'm fine though :P
> 
> What do you mean? Did I encourage the users somewhere?

I mean that instead of 'driver should reset on q num change' we could
have 'user should reset stats if wants them zeroed' :)

but this is not a strong opinion