netdev - Re: [PATCH net] tools: ynl: fix handling of multiple mcast groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4fccb2e2-97ac-4f16-8f56-53a38a269b69@6wind.com>
Date: Tue, 27 Feb 2024 17:41:02 +0100
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 willemb@...gle.com
Subject: Re: [PATCH net] tools: ynl: fix handling of multiple mcast groups

Le 26/02/2024 à 22:40, Jakub Kicinski a écrit :
> We never increment the group number iterator, so all groups
> get recorded into index 0 of the mcast_groups[] array.
> 
> As a result YNL can only handle using the last group.
> For example using the "netdev" sample on kernel with
> page pool commands results in:
> 
>   $ ./samples/netdev
>   YNL: Multicast group 'mgmt' not found
> 
> Most families have only one multicast group, so this hasn't
> been noticed. Plus perhaps developers usually test the last
> group which would have worked.
> 
> Fixes: 86878f14d71a ("tools: ynl: user space helpers")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>