netdev - Re: [PATCH net-next 1/2] net: bridge: Do not allocate stats in the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7d6e651-998a-4996-9b03-40d95edc84b5@blackwall.org>
Date: Tue, 27 Feb 2024 21:02:01 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Breno Leitao <leitao@...ian.org>, kuba@...nel.org, davem@...emloft.net,
 pabeni@...hat.com, edumazet@...gle.com, Roopa Prabhu <roopa@...dia.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, horms@...nel.org,
 "open list:ETHERNET BRIDGE" <bridge@...ts.linux.dev>
Subject: Re: [PATCH net-next 1/2] net: bridge: Do not allocate stats in the
 driver

On 2/27/24 20:23, Breno Leitao wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core
> instead of this driver.
> 
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
> 
> Remove the allocation in the bridge driver and leverage the network
> core allocation.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> ---
>   net/bridge/br_device.c | 13 ++-----------
>   1 file changed, 2 insertions(+), 11 deletions(-)
> 

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>