netdev - Re: [PATCH net] ethernet: adi: Move select PHYLIB from NET_VENDOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 26 Feb 2024 16:23:50 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Geert Uytterhoeven <geert@...ux-m68k.org>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] ethernet: adi: Move select PHYLIB from NET_VENDOR_ADI
 to ADIN1110

Hi Geert,

On 2/26/24 03:34, Geert Uytterhoeven wrote:
> The NET_VENDOR_* Kconfig options are used as gatekeepers.  Merely
> enabling such an option must not enable any other extra code.
> 
> Fixes: a9f80df4f5144030 ("net: ethernet: adi: requires PHYLIB support")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  drivers/net/ethernet/adi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/adi/Kconfig b/drivers/net/ethernet/adi/Kconfig
> index c91b4dcef4ec2f5f..760a9a60bc15c184 100644
> --- a/drivers/net/ethernet/adi/Kconfig
> +++ b/drivers/net/ethernet/adi/Kconfig
> @@ -7,7 +7,6 @@ config NET_VENDOR_ADI
>  	bool "Analog Devices devices"
>  	default y
>  	depends on SPI
> -	select PHYLIB
>  	help
>  	  If you have a network (Ethernet) card belonging to this class, say Y.
>  
> @@ -22,6 +21,7 @@ config ADIN1110
>  	tristate "Analog Devices ADIN1110 MAC-PHY"
>  	depends on SPI && NET_SWITCHDEV
>  	select CRC8
> +	select PHYLIB
>  	help
>  	  Say yes here to build support for Analog Devices ADIN1110
>  	  Low Power 10BASE-T1L Ethernet MAC-PHY.

I sent the same patch last night (local time):
https://lore.kernel.org/lkml/20240226074820.29250-1-rdunlap@infradead.org/

Hopefully one of them can be merged soon.

-- 
#Randy