netdev - Re: [PATCH v2 net-next 3/3] net: Use backlog-NAPI to clean up the defer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240227072714.qeSGBXNj@linutronix.de>
Date: Tue, 27 Feb 2024 08:27:14 +0100
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jesper Dangaard Brouer <hawk@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Wander Lairson Costa <wander@...hat.com>,
	Yan Zhai <yan@...udflare.com>
Subject: Re: [PATCH v2 net-next 3/3] net: Use backlog-NAPI to clean up the
 defer_list.

On 2024-02-26 17:22:33 [-0800], Jakub Kicinski wrote:
> On Mon, 26 Feb 2024 12:59:22 +0100 Sebastian Andrzej Siewior wrote:
> > They protect the list in input_pkt_queue and the NAPI state. It is just
> > in the !RPS case it is always CPU-local and the lock is avoided (while
> > interrupts are still disabled/ enabled).
> > 
> > What about
> > 	input_queue_lock_irq_save()
> > 	input_queue_lock_irq_disable()
> > 	input_queue_lock_irq_restore()
> > 	input_queue_lock_irq_enable()
> 
> SGTM. Maybe I'd risk calling it backlog_lock_* but not sure others
> would agree.

Let me repost it with backlog_lock_* today evening (UTC) unless someone
objects.

Sebastian